Skip to content

Conversation

Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested a review from yangw-dev December 19, 2025 21:53
@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
torchci Ready Ready Preview Dec 19, 2025 9:54pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2025
],
},
},
renders: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn I will add another auto component to add pure description for dashboard, it's good that we tells the differerence between this benchmark basedon pinned commit, and another one based on pinned pytorch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoBenchmarkMarkDownContent
#7615

name: "PyTorch x vLLM Benchmark",
route: `/benchmark/v3/dashboard/${PYTORCH_X_VLLM_BENCHMARK_ID}`,
info: "PyTorch x vLLM nightly benchmark. Powered by [code](TODO) and [benchmark configs](https://github.com/pytorch/pytorch-integration-testing/tree/main/vllm-benchmarks/benchmarks)",
description: "Pytorch x vLLM nightly benchmark using vllm bench",
Copy link
Contributor

@yangw-dev yangw-dev Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn recommend add comment that it's generated based on pinned vllm commit

Copy link
Contributor

@yangw-dev yangw-dev Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, maybe put this under vllm section: "vLLM Benchmarks ", instead of pytorch,
maybe also update the description for the vllmx pinned pytorch description, so that we can tell the difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants